impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5008: Fix reading stats for TINYINT and SMALLINT
Date Thu, 02 Mar 2017 21:26:15 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-5008: Fix reading stats for TINYINT and SMALLINT
......................................................................


Patch Set 2:

(3 comments)

Thanks for the review. Please see PS 3.

http://gerrit.cloudera.org:8080/#/c/6226/2/be/src/exec/parquet-column-stats.cc
File be/src/exec/parquet-column-stats.cc:

Line 34:         if (col_stats < std::numeric_limits<int8_t>::min() ||
> col_stats isn't valid if ret is false, right?
yes, fixed.


Line 39:           DCHECK(false);
> I don't think we should DCHECK here - users do sometimes run DEBUG builds o
I wasn't aware. Removed it.


Line 50:         if (col_stats < std::numeric_limits<int16_t>::min() ||
> See above comments.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6226
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9b10508db53747e7b08c8bd9a69c763b82135a78
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message