impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2328: Address additional comments
Date Thu, 02 Mar 2017 21:16:11 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-2328: Address additional comments
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/6147/4/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 494:     // Resolve the parquet column using schema_resolver_. This will perform either
name
a short single line will suffice here (no need to say 'using schema_resolver_', i can see
that; also no need to comment on how schema_resolver works; if there is additional need to
document that behavior, it should be done in the respective header file).

something like "resolve column path to determine col idx"


Line 505:       // during the scan, so any predicate would evaluate to false. Return early.
'<col> is null' would evaluate to true, did you cover that?


Line 512:       // In case there is a bug, we return an error, which will abort the query.
sounds like this should also be a dcheck, no?


-- 
To view, visit http://gerrit.cloudera.org:8080/6147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message