impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4675: Case-insensitive matching of Parquet fields.
Date Thu, 02 Mar 2017 21:10:41 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4675: Case-insensitive matching of Parquet fields.
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5891/4/tests/query_test/test_scanners.py
File tests/query_test/test_scanners.py:

Line 510:   def test_resolution_by_name(self, vector, unique_database):
> They are py.test fixtures, and the ordering should not matter.
Ah, right. They're using named parameters in the calls. That escaped me. I pushed a change
to fix the line in test_mt_dop.py.


-- 
To view, visit http://gerrit.cloudera.org:8080/5891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Nathan Salmon <nathan.gsalmon@gmail.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Nathan Salmon <nathan.gsalmon@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message