impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4998: Fix missing table lock acquisition.
Date Thu, 02 Mar 2017 07:02:23 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4998: Fix missing table lock acquisition.
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6177/5/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

PS5, Line 934: tbl instanceof IncompleteTable
> Not related to this change but I believe we load the metadata twice if we c
That's correct. It's a little tricky to fix because the first load is initiated during analysis
of the REFRESH stmt, and then once we get into the CatalogOpExecutor the table should be loaded,
so we would not load it again here in getOrLoadTable() (unless it got invalidated in the meantime).
I think we need to re-think the FE analysis of REFRESH to fix it.

This relates to some of the work Amos is doing.

I filed IMPALA-5012.


-- 
To view, visit http://gerrit.cloudera.org:8080/6177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message