impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4899: Fix parquet table writer dictionary leak
Date Wed, 01 Mar 2017 23:47:21 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-4899: Fix parquet table writer dictionary leak
......................................................................


Patch Set 4:

> is there a way to ascertain the leak-free behavior in a test?

I don't see a difference in the runtime profile with this patch vs without. The way I have
been testing is by hand. I do a clustered insert into a partitioned table and look at the
memory usage in top. It is a very clear difference, but I'm not sure how to write a test around
it. I tried setting a mem_limit and testing without my patch, but the mem_limit is not enforced.

-- 
To view, visit http://gerrit.cloudera.org:8080/6181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message