impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [native-toolchain-CR] IMPALA-5002: Associate toolchain build scripts/flags with built packages
Date Wed, 01 Mar 2017 22:19:50 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-5002: Associate toolchain build scripts/flags with built packages
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

Seems like a good thing to track

http://gerrit.cloudera.org:8080/#/c/6210/2/functions.sh
File functions.sh:

Line 351:   git rev-parse HEAD > ${BUILD_DIR}/${PACKAGE_STRING}${PATCH_VERSION}/toolchain-build-hash.txt
Long line


-- 
To view, visit http://gerrit.cloudera.org:8080/6210
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ida6f1eee0c20de7fbfdbb716e5c7ac8686b558b6
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message