impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Date Wed, 01 Mar 2017 03:50:33 GMT
Hello Tim Armstrong,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6171

to look at the new patch set (#2).

Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................

IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput

To test this, Matt Mulder ran the failing query from IMPALA-4995 on a
private cluster and it did not crash. However the query did not finish
within several hours. We should switch to using the Sorter for large
TopN queries, as tracked by IMPALA-5004.

Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
---
M be/src/exec/topn-node.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/6171/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message