impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-2328: Address additional comments
Date Wed, 01 Mar 2017 03:39:21 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2328: Address additional comments
......................................................................


Patch Set 3:

(3 comments)

Thanks for the review. Please see PS4.

http://gerrit.cloudera.org:8080/#/c/6147/3/be/src/exec/hdfs-parquet-scanner.cc
File be/src/exec/hdfs-parquet-scanner.cc:

Line 494:     SchemaNode* node = nullptr;
> prefix with comment that explains what you're doing.
Done


Line 509:       err << "Statistics not supported for pos fields: " << slot_desc->DebugString();
> 'pos fields' may not be very useful/comprehensible in the logging output.
I removed the logging output. This case should never happen, but in release builds or during
development I think it is preferable to display some sort of error message. Do you have a
suggestion how to improve it?


Line 511:       DCHECK(false) << err.str();
> Comment on the DCHECK here. We have it because the planner should not send 
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message