Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 25249200C29 for ; Tue, 14 Feb 2017 01:05:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 23A04160B6C; Tue, 14 Feb 2017 00:05:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6EB17160B60 for ; Tue, 14 Feb 2017 01:05:04 +0100 (CET) Received: (qmail 40074 invoked by uid 500); 14 Feb 2017 00:05:03 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 40063 invoked by uid 99); 14 Feb 2017 00:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Feb 2017 00:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 14AC5C1896 for ; Tue, 14 Feb 2017 00:05:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id GzvfcEsfzv8H for ; Tue, 14 Feb 2017 00:05:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 273775F570 for ; Tue, 14 Feb 2017 00:05:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1E04e7v019364; Tue, 14 Feb 2017 00:04:40 GMT Date: Tue, 14 Feb 2017 00:04:40 +0000 From: "Michael Ho (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: kwho@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4809=3A_Enable_support_for_DECIMAL_V2_in_decimal_casting=2Epy=0A?= X-Gerrit-Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3 X-Gerrit-ChangeURL: X-Gerrit-Commit: f19320d3749df2cb966466176a19d9befb1173a0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 14 Feb 2017 00:05:05 -0000 Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/5989 Change subject: IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py ...................................................................... IMPALA-4809: Enable support for DECIMAL_V2 in decimal_casting.py This change enables decimal_v2 for casting to decimal except for cases which involve rounding/truncation. In which case, we only enable decimal_v2 for casting from numbers to decimal. Due to prior misunderstanding, some of the changes made in commit 2088cf2 weren't necessary. By default, Impala interprets floating numbers as decimal unless they exceed the maximum decimal type supported. This change also removess a minor quirk: previously, the test will revert to using string to decimal casting for numbers larger than 2^63-1. This is unnecessary as Impala is able to treat numbers larger than that bound as decimal type. Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3 --- M tests/query_test/test_decimal_casting.py 1 file changed, 23 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/5989/1 -- To view, visit http://gerrit.cloudera.org:8080/5989 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icf2c8c9d360ad92cbdc5ce902ee742ec4408a8a3 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho