Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DEECD200C0F for ; Thu, 2 Feb 2017 22:33:18 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DD7EE160B57; Thu, 2 Feb 2017 21:33:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 341B1160B44 for ; Thu, 2 Feb 2017 22:33:18 +0100 (CET) Received: (qmail 11846 invoked by uid 500); 2 Feb 2017 21:33:17 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 11835 invoked by uid 99); 2 Feb 2017 21:33:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Feb 2017 21:33:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C07DCC1436 for ; Thu, 2 Feb 2017 21:33:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id pR6q3ymUQzGD for ; Thu, 2 Feb 2017 21:33:16 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C9F165F30D for ; Thu, 2 Feb 2017 21:33:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v12LX5en028121; Thu, 2 Feb 2017 21:33:05 GMT Date: Thu, 2 Feb 2017 21:33:05 +0000 From: "Matthew Jacobs (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org Message-ID: Reply-To: mj@cloudera.com X-Gerrit-MessageType: newchange Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4868=3A_Fix_flaky_TestRequestPoolService=2EtestUpdatingConfigs=0A?= X-Gerrit-Change-Id: Id94b59039363368d21ebb01cec18ae82d1390546 X-Gerrit-ChangeURL: X-Gerrit-Commit: 0aa26992880795358fe3567180ef90e43b0a9892 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 02 Feb 2017 21:33:19 -0000 Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/5876 Change subject: IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs ...................................................................... IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs Occasionally due to timing, testUpdatingConfigs() fails in jenkins jobs. This can be reproduced by manually changing the sleep times in the test. The fix is to attempt checking the results several times, sleeping briefly in between attempts. Testing: Manually changed the sleep times to simulate failure and success cases. Change-Id: Id94b59039363368d21ebb01cec18ae82d1390546 --- M fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java 1 file changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/5876/1 -- To view, visit http://gerrit.cloudera.org:8080/5876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id94b59039363368d21ebb01cec18ae82d1390546 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs