Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 47BD2200C29 for ; Tue, 28 Feb 2017 20:31:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 463F5160B7C; Tue, 28 Feb 2017 19:31:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8F456160B59 for ; Tue, 28 Feb 2017 20:31:55 +0100 (CET) Received: (qmail 36907 invoked by uid 500); 28 Feb 2017 19:31:54 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 36896 invoked by uid 99); 28 Feb 2017 19:31:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2017 19:31:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 31044C1901 for ; Tue, 28 Feb 2017 19:31:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Jz5eDbsrtG5D for ; Tue, 28 Feb 2017 19:31:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4215A5FB43 for ; Tue, 28 Feb 2017 19:31:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1SJVpJt011869; Tue, 28 Feb 2017 19:31:51 GMT Message-Id: <201702281931.v1SJVpJt011869@ip-10-146-233-104.ec2.internal> Date: Tue, 28 Feb 2017 19:31:51 +0000 From: "Lars Volker (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Jim Apple Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4997=3A_Fix_overflows_in_Sorter=3A=3ATupleIterator=0A?= X-Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8 X-Gerrit-ChangeURL: X-Gerrit-Commit: c8726476f5f55f02eaac3c6fe42dcf0411b8b69d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 28 Feb 2017 19:31:56 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator ...................................................................... Patch Set 7: Code-Review+2 Updated the commit message. Carrying the +2 from Jim and Marcel -- To view, visit http://gerrit.cloudera.org:8080/6169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: No