Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 65489200C29 for ; Tue, 28 Feb 2017 20:00:34 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 63CEE160B7C; Tue, 28 Feb 2017 19:00:34 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AC67F160B59 for ; Tue, 28 Feb 2017 20:00:33 +0100 (CET) Received: (qmail 36396 invoked by uid 500); 28 Feb 2017 19:00:33 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 36385 invoked by uid 99); 28 Feb 2017 19:00:32 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2017 19:00:32 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 486FBC05B0 for ; Tue, 28 Feb 2017 19:00:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4avmKvRY-Urf for ; Tue, 28 Feb 2017 19:00:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 8D0AA5F403 for ; Tue, 28 Feb 2017 19:00:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1SJ0TBJ010603; Tue, 28 Feb 2017 19:00:29 GMT Message-Id: <201702281900.v1SJ0TBJ010603@ip-10-146-233-104.ec2.internal> Date: Tue, 28 Feb 2017 19:00:29 +0000 From: "Bharath Vissapragada (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4998=3A_Fix_missing_table_lock_acquisition=2E=0A?= X-Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe X-Gerrit-ChangeURL: X-Gerrit-Commit: 4afe9d03a9819cd7126d45618fae1d44525e3313 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 28 Feb 2017 19:00:34 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4998: Fix missing table lock acquisition. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6177/3/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: Line 768: if (tbl == null || tbl.isLoaded()) return tbl; I'm wondering if this can potentially return an IncompleteTable and that eventually hits the preconditions check in reloadTable(). Reason being, IncompleteTable.isLoaded() needn't always return false. > public boolean isLoaded() { return cause_ != null; } Especially the static method that we use to create IncompleteTables sets the cause_ as null. public static IncompleteTable createUninitializedTable(Db db, String name) { return new IncompleteTable(db, name, null); } Please correct me if I'm wrong. PS3, Line 926: which not be rephrase? -- To view, visit http://gerrit.cloudera.org:8080/6177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e0270daf59fce95f1a1520fc5aaf91d3a7b99fe Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-HasComments: Yes