Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0A448200C3D for ; Tue, 28 Feb 2017 02:38:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 08E89160B6C; Tue, 28 Feb 2017 01:38:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 527CB160B60 for ; Tue, 28 Feb 2017 02:38:27 +0100 (CET) Received: (qmail 7234 invoked by uid 500); 28 Feb 2017 01:38:26 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 7222 invoked by uid 99); 28 Feb 2017 01:38:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Feb 2017 01:38:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DEFE21A0270 for ; Tue, 28 Feb 2017 01:38:25 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id yUgvHCLh4xs2 for ; Tue, 28 Feb 2017 01:38:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 840855F5F7 for ; Tue, 28 Feb 2017 01:38:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1S1cNVm027306; Tue, 28 Feb 2017 01:38:23 GMT Message-Id: <201702280138.v1S1cNVm027306@ip-10-146-233-104.ec2.internal> Date: Tue, 28 Feb 2017 01:38:23 +0000 From: "Henry Robinson (Code Review)" To: Bharath Vissapragada , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dimitris Tsirogiannis , Alex Behm , Marcel Kornacker Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4822=3A_Implement_dynamic_log_level_changes=0A?= X-Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 X-Gerrit-ChangeURL: X-Gerrit-Commit: adc07fefd6156aa073fdd06a6082f4906d9bc765 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Tue, 28 Feb 2017 01:38:28 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5792/13/be/src/util/logging-support.cc File be/src/util/logging-support.cc: Line 40 > Yes, Interestingly that has always been the behavior (even without this pat Right, but the idea is that if we want to turn off trace debugging, for example, we can use the usual controls to do so (by setting GLOG_v < 3). What happens with trace log messages now? Are they always printed? -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes