Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 68E3A200C34 for ; Mon, 27 Feb 2017 20:58:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6765D160B60; Mon, 27 Feb 2017 19:58:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B11DC160B5B for ; Mon, 27 Feb 2017 20:58:07 +0100 (CET) Received: (qmail 46638 invoked by uid 500); 27 Feb 2017 19:58:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 46627 invoked by uid 99); 27 Feb 2017 19:58:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Feb 2017 19:58:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4DC6FC1089 for ; Mon, 27 Feb 2017 19:58:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 7-JPGGQcvW2O for ; Mon, 27 Feb 2017 19:58:05 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8ACA55FE16 for ; Mon, 27 Feb 2017 19:58:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1RJw471013240; Mon, 27 Feb 2017 19:58:04 GMT Message-Id: <201702271958.v1RJw471013240@ip-10-146-233-104.ec2.internal> Date: Mon, 27 Feb 2017 19:58:04 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Lars Volker Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_Scheduler_abstract_interface=2C_rename_SimpleScheduler_-=3E_Scheduler=0A?= X-Gerrit-Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e X-Gerrit-ChangeURL: X-Gerrit-Commit: 736ee883b102a571a3e4195b5a824cf4f0679b14 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 27 Feb 2017 19:58:08 -0000 Henry Robinson has posted comments on this change. Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler ...................................................................... Patch Set 2: (1 comment) I've reverted the renames, temporarily, for easy review. I haven't reverted the CMakeFiles or includes so this patch won't compile. http://gerrit.cloudera.org:8080/#/c/6149/1/be/src/scheduling/scheduler.h File be/src/scheduling/scheduler.h: Line 18 > revert. Done -- To view, visit http://gerrit.cloudera.org:8080/6149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes