Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2DF08200C36 for ; Fri, 24 Feb 2017 02:20:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2C945160B67; Fri, 24 Feb 2017 01:20:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 71423160B64 for ; Fri, 24 Feb 2017 02:20:00 +0100 (CET) Received: (qmail 59178 invoked by uid 500); 24 Feb 2017 01:19:59 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59167 invoked by uid 99); 24 Feb 2017 01:19:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 01:19:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0E9BF18E5ED for ; Fri, 24 Feb 2017 01:19:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8vHt_MHpxFn6 for ; Fri, 24 Feb 2017 01:19:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A640C618B0 for ; Fri, 24 Feb 2017 01:19:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1O1JtHb027503; Fri, 24 Feb 2017 01:19:56 GMT Message-Id: <201702240119.v1O1JtHb027503@ip-10-146-233-104.ec2.internal> Date: Fri, 24 Feb 2017 01:19:55 +0000 From: "Lars Volker (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Alex Behm Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4982=3A_Add_parquet_stats_test=0A?= X-Gerrit-Change-Id: If81c8a1ecea937794885d4e5e7bf765bd238f5fb X-Gerrit-ChangeURL: X-Gerrit-Commit: f98a9ad6b04c823c093a17d1a9583e6a3ad251d1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 24 Feb 2017 01:20:01 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-4982: Add parquet stats test ...................................................................... Patch Set 3: (2 comments) Thank you for the review! Please see my comments and PS4. http://gerrit.cloudera.org:8080/#/c/6130/3/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test: Line 232: ---- QUERY > Move these into a separate .test file or find another suitable test/file (e Thank you for catching this. I moved the tests into a new file, anticipating we will add more tests there as we add support for filtering nested data. Line 252: # Nested columns do not support stats based filtering. > Do we have a JIRA for this yet? We can definitely fix this. I opened IMPALA-4985 to track this. -- To view, visit http://gerrit.cloudera.org:8080/6130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If81c8a1ecea937794885d4e5e7bf765bd238f5fb Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Lars Volker Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Lars Volker Gerrit-HasComments: Yes