Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9B842200C23 for ; Wed, 22 Feb 2017 19:06:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9A0F4160B62; Wed, 22 Feb 2017 18:06:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DC6E9160B49 for ; Wed, 22 Feb 2017 19:06:10 +0100 (CET) Received: (qmail 68760 invoked by uid 500); 22 Feb 2017 18:06:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 68749 invoked by uid 99); 22 Feb 2017 18:06:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Feb 2017 18:06:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 65B131AA2A4 for ; Wed, 22 Feb 2017 18:06:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 2iH2CGGyUEZI for ; Wed, 22 Feb 2017 18:06:07 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id E57E55FB89 for ; Wed, 22 Feb 2017 18:06:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1MI63ce025620; Wed, 22 Feb 2017 18:06:03 GMT Message-Id: <201702221806.v1MI63ce025620@ip-10-146-233-104.ec2.internal> Date: Wed, 22 Feb 2017 18:06:03 +0000 From: "Dan Hecht (Code Review)" To: Zach Amsden , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho , Marcel Kornacker Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2020=2C_4915=2C_4936=3A_Add_rounding_for_decimal_casts=0A?= X-Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 X-Gerrit-ChangeURL: X-Gerrit-Commit: 86da785e48ff066b402c9ab320bf932de50d53de In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 22 Feb 2017 18:06:11 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-2020, 4915, 4936: Add rounding for decimal casts ...................................................................... Patch Set 21: Code-Review+2 (2 comments) Michael, can you take a final pass as well? http://gerrit.cloudera.org:8080/#/c/5951/19/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1621: { false, -1000, 5, 0 }}}, could you add a comment saying how many fives that is. I counted 38, so why does this overflow? http://gerrit.cloudera.org:8080/#/c/5951/21/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: PS21, Line 110: abs why not std:abs() here? -- To view, visit http://gerrit.cloudera.org:8080/5951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2daf186b4770a022f9cb349d512067a1dd624810 Gerrit-PatchSet: 21 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes