Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9CD74200C31 for ; Wed, 22 Feb 2017 06:47:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 80628160B74; Wed, 22 Feb 2017 05:47:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C8F4E160B68 for ; Wed, 22 Feb 2017 06:47:52 +0100 (CET) Received: (qmail 28044 invoked by uid 500); 22 Feb 2017 05:47:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 28033 invoked by uid 99); 22 Feb 2017 05:47:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Feb 2017 05:47:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 358E11896AB for ; Wed, 22 Feb 2017 05:47:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id iEpo6zpzcsAt for ; Wed, 22 Feb 2017 05:47:50 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 463955F477 for ; Wed, 22 Feb 2017 05:47:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1M5lkoK015860; Wed, 22 Feb 2017 05:47:46 GMT Message-Id: <201702220547.v1M5lkoK015860@ip-10-146-233-104.ec2.internal> Date: Wed, 22 Feb 2017 05:47:46 +0000 From: "Zach Amsden (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Jim Apple , Michael Ho Reply-To: zamsden@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4936_and_IMPALA-4915=3A_Fix_decimal_overflow_test=0A?= X-Gerrit-Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63 X-Gerrit-ChangeURL: X-Gerrit-Commit: b1350dadf734d582bb2c2a4ab54de96908a4fa99 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Wed, 22 Feb 2017 05:47:53 -0000 Zach Amsden has posted comments on this change. Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test ...................................................................... Patch Set 2: (3 comments) I'm folding this into the cast change anyway. http://gerrit.cloudera.org:8080/#/c/6068/1//COMMIT_MSG Commit Message: Line 22: > I think this probably should be fixed in this commit. This was a real problem, found it. http://gerrit.cloudera.org:8080/#/c/6068/2/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS2, Line 1397: true > Sorry, I may be missing something. Why is this NULL ? I am missing something too... was the test broken before? Line 1635: TestIsNotNull(c.expr, type); I added this because I noticed the non-NULL test cases were passing even when the value happened to match, which was the case for some zero values. Looks like something is broken with modulus. -- To view, visit http://gerrit.cloudera.org:8080/6068 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes