Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 962B4200C2C for ; Fri, 17 Feb 2017 07:02:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 94D3A160B6F; Fri, 17 Feb 2017 06:02:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF87A160B61 for ; Fri, 17 Feb 2017 07:02:54 +0100 (CET) Received: (qmail 86305 invoked by uid 500); 17 Feb 2017 06:02:54 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 86294 invoked by uid 99); 17 Feb 2017 06:02:53 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 06:02:53 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6A8D0186112 for ; Fri, 17 Feb 2017 06:02:53 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id vkQX91Xd6xfX for ; Fri, 17 Feb 2017 06:02:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id CD3705F23F for ; Fri, 17 Feb 2017 06:02:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1H62nCK021052; Fri, 17 Feb 2017 06:02:49 GMT Message-Id: <201702170602.v1H62nCK021052@ip-10-146-233-104.ec2.internal> Date: Fri, 17 Feb 2017 06:02:49 +0000 From: "Impala Public Jenkins (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4854=3A_Fix_incremental_stats_with_complex_types=2E=0A?= X-Gerrit-Change-Id: I6e0335048d688ee25ff55c6628d0f6f8ecc1dd8a X-Gerrit-ChangeURL: X-Gerrit-Commit: d845413ab8fb0c92fc2d8d0c2a54d0de4dbd7429 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 17 Feb 2017 06:02:55 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4854: Fix incremental stats with complex types. ...................................................................... IMPALA-4854: Fix incremental stats with complex types. The bug: Compute incremental stats used to always do a full stats recomputation for tables with complex types. The logic for detecting schema changes (e.g. an added column) did not take into consideration that columns with complex types are ignored in the stats computation, and should therefore not be recognized as a new column that does not yet have stats. Testing: - Added a new regression test - Locally ran test_compute_stats.py and the FE tests Change-Id: I6e0335048d688ee25ff55c6628d0f6f8ecc1dd8a Reviewed-on: http://gerrit.cloudera.org:8080/6033 Reviewed-by: Alex Behm Tested-by: Impala Public Jenkins --- M fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java M testdata/workloads/functional-query/queries/QueryTest/compute-stats-incremental.test 2 files changed, 47 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/6033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e0335048d688ee25ff55c6628d0f6f8ecc1dd8a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Impala Public Jenkins