Return-Path:
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
by cust-asf2.ponee.io (Postfix) with ESMTP id 310C9200C1D
for ; Thu, 16 Feb 2017 19:16:21 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
id 2FBB9160B61; Thu, 16 Feb 2017 18:16:21 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by cust-asf.ponee.io (Postfix) with SMTP id 79608160B52
for ; Thu, 16 Feb 2017 19:16:20 +0100 (CET)
Received: (qmail 56802 invoked by uid 500); 16 Feb 2017 18:16:19 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help:
List-Unsubscribe:
List-Post:
List-Id:
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 56785 invoked by uid 99); 16 Feb 2017 18:16:19 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142)
by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Feb 2017 18:16:19 +0000
Received: from localhost (localhost [127.0.0.1])
by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9AE74C0C5F
for ; Thu, 16 Feb 2017 18:16:18 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.363
X-Spam-Level:
X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31
tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001]
autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024)
with ESMTP id yO5XI77Tr0US for ;
Thu, 16 Feb 2017 18:16:17 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 252F95F19B
for ; Thu, 16 Feb 2017 18:16:17 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1GIGFl9028495;
Thu, 16 Feb 2017 18:16:15 GMT
Message-Id: <201702161816.v1GIGFl9028495@ip-10-146-233-104.ec2.internal>
Date: Thu, 16 Feb 2017 18:16:15 +0000
From: "John Russell (Code Review)"
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Matthew Jacobs , Todd Lipcon ,
Jean-Daniel Cryans ,
Ambreen Kazi ,
Dimitris Tsirogiannis
Reply-To: jrussell@cloudera.com
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_=5BDOCS=5D_Major_update_to_Impala_+_Kudu_page=0A?=
X-Gerrit-Change-Id: I76dcb948dab08532fe41326b22ef78d73282db2c
X-Gerrit-ChangeURL:
X-Gerrit-Commit: f0c9bc61dc6521f5090f2bc329744c0288464a48
In-Reply-To:
References:
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.7
archived-at: Thu, 16 Feb 2017 18:16:21 -0000
John Russell has posted comments on this change.
Change subject: [DOCS] Major update to Impala + Kudu page
......................................................................
Patch Set 15:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/5649/14/docs/topics/impala_explain.xml
File docs/topics/impala_explain.xml:
Line 269: literal values that exactly match the types in the Kudu table, and do not
> Binary predicates and IN list predicates can be pushed to Kudu.
Done
http://gerrit.cloudera.org:8080/#/c/5649/14/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
PS14, Line 147: Tablets are
: stored by tablet servers
> 'work' and 'computing' is kind of misleading given kudu is storage. How abo
Done
PS14, Line 150: Where practical, colocate the tablet servers on the same hosts as the DataNodes, although that is not
> Though our recommendation will be to colocate Impalads with tservers.
Done
PS14, Line 220: duplicate
> duplicating
Leaving this as-is. You are avoid the condition of having duplicate data, not the action of duplicating the data.
PS14, Line 220: On the logical side, the uniqueness constraint allows you to avoid duplicate data in a table.
> I like this positive spin on our consistency limitations
Done. Hey, there's a ton of stuff that I wrote in the Oracle docs about the positives of being able to tighten or loosen the constraints on duplicates depending on the circumstances.
PS14, Line 546: BIT_SHUFFLE: rearrange the bits of the values to efficiently
: compress sequences of values that are identical or vary only slightly based
: on primary key order.
> according to the compression doc below, this is also compressed with lz4 af
Done
PS14, Line 562: No joy trying keywords UNKNOWN, or GROUP_VARINT with TINYINT and BIGINT.
> can you file a JIRA please
Done. https://issues.cloudera.org/browse/IMPALA-4922
PS14, Line 1100:
: See
> this doesnt render in the pdf
The relevant link destination is filled in via a different gerrit, not to worry.
PS14, Line 1153: In particular, do not rely on an INSERT ... SELECT statement
: that selects from the same table into which it is inserting, unless you include extra
: conditions in the WHERE clause to avoid reading the newly inserted rows
: within the same statement
> this gets repeated very similarly in the next section. not sure which one i
Done. It's intentional so I'll leave it as-is for the moment. One is "here's how to take this quirk into account during ETL" and the other is "here's the details of the quirk".
PS14, Line 1237: data that is read while a write
: operation is in progress
> kudu does have atomic per row operations, so this needs to be clear it refe
Done
http://gerrit.cloudera.org:8080/#/c/5649/14/docs/topics/impala_literals.xml
File docs/topics/impala_literals.xml:
PS14, Line 401: kudu_bl
This should actually be kudu_blurb to produce the Kudu-specific subheading.
PS14, Line 409: are part of the primary key.
> this is not true, default is nullable except for PK cols
Done
PS14, Line 415:
:
This constraint applies to every column, not to the composite value of all the PK columns.
--
To view, visit http://gerrit.cloudera.org:8080/5649
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76dcb948dab08532fe41326b22ef78d73282db2c
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell
Gerrit-Reviewer: Ambreen Kazi
Gerrit-Reviewer: Dimitris Tsirogiannis
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: John Russell
Gerrit-Reviewer: Matthew Jacobs
Gerrit-Reviewer: Todd Lipcon
Gerrit-HasComments: Yes