Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9E6A8200C1A for ; Mon, 13 Feb 2017 22:46:25 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9B5DA160B60; Mon, 13 Feb 2017 21:46:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E34C4160B4A for ; Mon, 13 Feb 2017 22:46:24 +0100 (CET) Received: (qmail 92263 invoked by uid 500); 13 Feb 2017 21:46:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92246 invoked by uid 99); 13 Feb 2017 21:46:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 21:46:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 72D4A186137 for ; Mon, 13 Feb 2017 21:46:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Ly3iDQhr3e1P for ; Mon, 13 Feb 2017 21:46:22 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 815685F29A for ; Mon, 13 Feb 2017 21:46:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1DLkL5J013548; Mon, 13 Feb 2017 21:46:21 GMT Message-Id: <201702132146.v1DLkL5J013548@ip-10-146-233-104.ec2.internal> Date: Mon, 13 Feb 2017 21:46:21 +0000 From: "Jim Apple (Code Review)" To: Michael Brown , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , David Knupp Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4920=3A_custom_cluster_tests=3A_remove_unnecessary_escaped_quote_chars=0A?= X-Gerrit-Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6 X-Gerrit-ChangeURL: X-Gerrit-Commit: bc45dba0be4b7f1ade1450ac179e31e5011e6f03 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 13 Feb 2017 21:46:25 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5978/1//COMMIT_MSG Commit Message: Line 7: IMPALA-4920: custom cluster tests: remove unnecessary escaped quote chars > Is our policy 72 chars for commit messages then? It seems to be common practice. $ git log | grep -oE '^ ([^ ].*)$' | cut -d ' ' -f 5- | awk '{print length;}' | sort -n | uniq -c ... 941 65 1059 66 1197 67 1680 68 1435 69 1426 70 1137 71 1118 72 368 73 325 74 349 75 327 76 ... -- To view, visit http://gerrit.cloudera.org:8080/5978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If6a56bc6bca826a8b50340e5caea7687441899e6 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Brown Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes