Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7FF95200C1A for ; Mon, 13 Feb 2017 19:34:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7EC1A160B60; Mon, 13 Feb 2017 18:34:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C57FB160B4A for ; Mon, 13 Feb 2017 19:34:47 +0100 (CET) Received: (qmail 29405 invoked by uid 500); 13 Feb 2017 18:34:47 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 29389 invoked by uid 99); 13 Feb 2017 18:34:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2017 18:34:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 445BE18613C for ; Mon, 13 Feb 2017 18:34:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id mSgTBrxdDUxV for ; Mon, 13 Feb 2017 18:34:45 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id D81CF5FBE2 for ; Mon, 13 Feb 2017 18:34:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1DIYWve006421; Mon, 13 Feb 2017 18:34:32 GMT Message-Id: <201702131834.v1DIYWve006421@ip-10-146-233-104.ec2.internal> Date: Mon, 13 Feb 2017 18:34:32 +0000 From: "Ambreen Kazi (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , John Russell , Laurel Hale Reply-To: ambreen.kazi@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3411_=5BDOCS=5D_Rework_Impala_governance_topics_to_be_generic=2E=0A?= X-Gerrit-Change-Id: I192bc2d1de89e55418c045d1a0e5433cf02cf782 X-Gerrit-ChangeURL: X-Gerrit-Commit: d563d3272d33643cc66a7514830336acfc9e510b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Mon, 13 Feb 2017 18:34:48 -0000 Ambreen Kazi has posted comments on this change. Change subject: IMPALA-3411 [DOCS] Rework Impala governance topics to be generic. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5957/1//COMMIT_MSG Commit Message: Line 12: to use cluster management software with a focus on governance. > Why not always remove them? We will eventually remove them from the source once we've sanity checked individual topics and made sure that what remains outside the hidden tags is not awkward and flows well. Removing all the 'hidden' content will be a global operation. For now though, with three writers working on the source, it's not a good idea to spot fix these references. http://gerrit.cloudera.org:8080/#/c/5957/2/docs/topics/impala_lineage.xml File docs/topics/impala_lineage.xml: Line 61: lineage data generated by Impala into graphs for easy visualization. > These are no longer hidden and there is a mismatched ph tag at the end. Thanks -- fixed the ph tag and another missing p tag -- the text is hidden in my build now. -- To view, visit http://gerrit.cloudera.org:8080/5957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I192bc2d1de89e55418c045d1a0e5433cf02cf782 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Ambreen Kazi Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-Reviewer: Laurel Hale Gerrit-HasComments: Yes