Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5BFAD200C17 for ; Fri, 10 Feb 2017 09:42:23 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 58F9C160B5C; Fri, 10 Feb 2017 08:42:23 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id A446D160B5B for ; Fri, 10 Feb 2017 09:42:22 +0100 (CET) Received: (qmail 31318 invoked by uid 500); 10 Feb 2017 08:42:21 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 31307 invoked by uid 99); 10 Feb 2017 08:42:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Feb 2017 08:42:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1BF33180B10 for ; Fri, 10 Feb 2017 08:42:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id byBcqt1rvnS1 for ; Fri, 10 Feb 2017 08:42:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id ED1D95FDEA for ; Fri, 10 Feb 2017 08:42:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1A8gI1H010090; Fri, 10 Feb 2017 08:42:18 GMT Message-Id: <201702100842.v1A8gI1H010090@ip-10-146-233-104.ec2.internal> Date: Fri, 10 Feb 2017 08:42:18 +0000 From: "Marcel Kornacker (Code Review)" To: Bharath Vissapragada , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Henry Robinson , Dimitris Tsirogiannis , Alex Behm Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4822=3A_Implement_dynamic_log_level_changes=0A?= X-Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 X-Gerrit-ChangeURL: X-Gerrit-Commit: a46cdd6463fbc43eafdb6a4e78eae193218bc7c1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 10 Feb 2017 08:42:23 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4822: Implement dynamic log level changes ...................................................................... Patch Set 12: > Marcel, you can make changes like you described just with a URL, > see test_web_pages.py which does just that. The UI is nice because > then you also have a way of inspecting the state of the system. > Allowing mutation without having a way to inspect the state seems > bad for usability (and esp. if we expose it to users). I didn't suggest not allowing inspection of the existing log levels, which can also be done via a url. I'm not sure the extra complexity of the UI is worth it. -- To view, visit http://gerrit.cloudera.org:8080/5792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: No