Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C3D56200C17 for ; Fri, 10 Feb 2017 09:36:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C28BC160B6C; Fri, 10 Feb 2017 08:36:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 174FE160B5C for ; Fri, 10 Feb 2017 09:36:36 +0100 (CET) Received: (qmail 8258 invoked by uid 500); 10 Feb 2017 08:36:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 8214 invoked by uid 99); 10 Feb 2017 08:36:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Feb 2017 08:36:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 93848C3442 for ; Fri, 10 Feb 2017 08:36:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KBsK986EdSR9 for ; Fri, 10 Feb 2017 08:36:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 83F0E5F342 for ; Fri, 10 Feb 2017 08:36:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v1A8aU1r009954; Fri, 10 Feb 2017 08:36:30 GMT Message-Id: <201702100836.v1A8aU1r009954@ip-10-146-233-104.ec2.internal> Date: Fri, 10 Feb 2017 08:36:30 +0000 From: "Marcel Kornacker (Code Review)" To: Dan Hecht , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho , Zach Amsden , Alex Behm Reply-To: marcel@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4810=3A_Make_DECIMAL_expr-test_cases_table_driven=0A?= X-Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8de2884e8ba635c51af4f5d6fe8d12a369db4bd6 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Fri, 10 Feb 2017 08:36:37 -0000 Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4810: Make DECIMAL expr-test cases table driven ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5933/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1288: {{ false, 2230, 5, 3 }, { false, 2230, 5, 3 }} }, > The next patch introduces actual differences, and lines up each pair of exp but how about changing it so if the result is the same in both versions, you only need to specify it once? that would help readability quite a bit. -- To view, visit http://gerrit.cloudera.org:8080/5933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieffb2573de46bba64d1b4e8caf15cc0238a84ea1 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes