Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DCAA8200C25 for ; Fri, 10 Feb 2017 00:23:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DB0DE160B64; Thu, 9 Feb 2017 23:23:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 31B44160B50 for ; Fri, 10 Feb 2017 00:23:56 +0100 (CET) Received: (qmail 85015 invoked by uid 500); 9 Feb 2017 23:23:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 85002 invoked by uid 99); 9 Feb 2017 23:23:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Feb 2017 23:23:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C8CFC18285E for ; Thu, 9 Feb 2017 23:23:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id uRE2d2uN59WP for ; Thu, 9 Feb 2017 23:23:53 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id A84E75F1B3 for ; Thu, 9 Feb 2017 23:23:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v19NNqMP030228; Thu, 9 Feb 2017 23:23:53 GMT Message-Id: <201702092323.v19NNqMP030228@ip-10-146-233-104.ec2.internal> Date: Thu, 9 Feb 2017 23:23:52 +0000 From: "Dan Hecht (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Michael Ho , Zach Amsden Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4810=3A_fix_incorrect_expr-test_decimal_types=0A?= X-Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b X-Gerrit-ChangeURL: X-Gerrit-Commit: 8852a4c729ff137057cddcfbaf2bf4616c1a1080 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.7 archived-at: Thu, 09 Feb 2017 23:23:57 -0000 Dan Hecht has uploaded a new patch set (#2). Change subject: IMPALA-4810: fix incorrect expr-test decimal types ...................................................................... IMPALA-4810: fix incorrect expr-test decimal types Many of the types for the decimal round/truncate and related tests are incorrect. This was never caught because the type was only used by the string parser, and larger types would work. The change for IMPALA-4370 adds validation of the expected type, so fix these. Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b --- M be/src/exprs/expr-test.cc M be/src/runtime/types.cc 2 files changed, 101 insertions(+), 87 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/5959/2 -- To view, visit http://gerrit.cloudera.org:8080/5959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1e750fc01ab64ff27182670d8e823c012743804b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Zach Amsden