Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 74990200C39 for ; Thu, 9 Feb 2017 00:05:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 73582160B67; Wed, 8 Feb 2017 23:05:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BB93B160B6A for ; Thu, 9 Feb 2017 00:05:44 +0100 (CET) Received: (qmail 61622 invoked by uid 500); 8 Feb 2017 23:05:44 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 61571 invoked by uid 99); 8 Feb 2017 23:05:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2017 23:05:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 595EBC05D7 for ; Wed, 8 Feb 2017 23:05:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id kMs-Xzf6T2hk for ; Wed, 8 Feb 2017 23:05:42 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 07FB15F24B for ; Wed, 8 Feb 2017 23:05:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v18N5Y6s010072; Wed, 8 Feb 2017 23:05:34 GMT Message-Id: <201702082305.v18N5Y6s010072@ip-10-146-233-104.ec2.internal> Date: Wed, 8 Feb 2017 23:05:34 +0000 From: "Alex Behm (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Michael Ho , Dan Hecht Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1430=2CIMPALA-4878=2CIMPALA-4879=3A_codegen_native_UDAs=0A?= X-Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f X-Gerrit-ChangeURL: X-Gerrit-Commit: e4e657fc6ebc7aea916d0cdd26f4190a42aa2a57 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 08 Feb 2017 23:05:45 -0000 Alex Behm has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs ...................................................................... Patch Set 20: (2 comments) FE lgtm +2 http://gerrit.cloudera.org:8080/#/c/5161/20/fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java File fe/src/main/java/org/apache/impala/analysis/FunctionCallExpr.java: Line 106: ArrayList aggFnArgTypes = Lists.newArrayList(); unused? Line 554: "in original expr %s", toSql(), copiedInputType.toString(), also use toSql() for types -- To view, visit http://gerrit.cloudera.org:8080/5161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f Gerrit-PatchSet: 20 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes