Return-Path:
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
by cust-asf2.ponee.io (Postfix) with ESMTP id 1CCA4200C15
for ; Wed, 8 Feb 2017 23:25:12 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
id 1B780160B5A; Wed, 8 Feb 2017 22:25:12 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by cust-asf.ponee.io (Postfix) with SMTP id 63530160B49
for ; Wed, 8 Feb 2017 23:25:11 +0100 (CET)
Received: (qmail 88057 invoked by uid 500); 8 Feb 2017 22:25:10 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help:
List-Unsubscribe:
List-Post:
List-Id:
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 88046 invoked by uid 99); 8 Feb 2017 22:25:10 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2017 22:25:10 +0000
Received: from localhost (localhost [127.0.0.1])
by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E930BC05D7
for ; Wed, 8 Feb 2017 22:25:09 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.362
X-Spam-Level:
X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31
tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
with ESMTP id 0UkuSapWyOAv for ;
Wed, 8 Feb 2017 22:25:07 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 0BD245F589
for ; Wed, 8 Feb 2017 22:25:07 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v18MP1Ze008180;
Wed, 8 Feb 2017 22:25:01 GMT
Message-Id: <201702082225.v18MP1Ze008180@ip-10-146-233-104.ec2.internal>
Date: Wed, 8 Feb 2017 22:25:01 +0000
From: "Ambreen Kazi (Code Review)"
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Jim Apple ,
John Russell ,
Laurel Hale
Reply-To: ambreen.kazi@cloudera.com
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3410_=5BDOCS=5D_Rework_Impala_security_topics_to_be_generic=0A?=
X-Gerrit-Change-Id: Ie5c4431f3236b18fc282343ed98513f0e578130e
X-Gerrit-ChangeURL:
X-Gerrit-Commit: c624d0dd63d77af1f2ca72c19ef50b06ff41b229
In-Reply-To:
References:
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 08 Feb 2017 22:25:12 -0000
Ambreen Kazi has posted comments on this change.
Change subject: IMPALA-3410 [DOCS] Rework Impala security topics to be generic
......................................................................
Patch Set 1:
(14 comments)
http://gerrit.cloudera.org:8080/#/c/5931/1//COMMIT_MSG
Commit Message:
Line 10: topics. References to CDH and Cloudera Manager docs/products have been either
> wrap at 70 characters (the red line)
Done
http://gerrit.cloudera.org:8080/#/c/5931/1/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
PS1, Line 608: audience="Cloudera"
> This should be audience="hidden". (There shouldn't be any audience="Clouder
I found it like this. Changed to hidden now.
PS1, Line 616: appropropriate
> note to self - typo
Done
http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_authorization.xml
File docs/topics/impala_authorization.xml:
PS1, Line 319: recommends
: managing privileges through SQL statements, as described in
: . If you are still using policy files, plan to
: migrate to the new approach some time in the future.
> Should we genericize the wording but keep the recommendation to use policy
Genericized the wording. The recommendation should be to use the SQL statements. I've removed the 'some time in the future' wording as well because it's been a while since the Sentry service released.
Line 850: To enable URIs in per-DB policy files, the Java configuration option sentry.allow.uri.db.policyfile must be set to true.
> Shorter lines maker for easier reviews
Done
PS1, Line 853:
> For example:
Done
PS1, Line 951: we strongly recommend
> I've stayed away from "we recommend" because there isn't the same commitmen
I've reworded this note to make it more of an instruction rather than a suggestion/recommendation.
http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_security.xml
File docs/topics/impala_security.xml:
PS1, Line 40: the Apache Sentry
: open source project
> Optional: can be shortened to just "Apache Sentry".
Done
PS1, Line 45: focussed
> focused (American spelling)
Done
PS1, Line 116:
> hyphen, like previous instance
Done
http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_security_install.xml
File docs/topics/impala_security_install.xml:
PS1, Line 38:
> Trailing blank.
Done
http://gerrit.cloudera.org:8080/#/c/5931/1/docs/topics/impala_ssl.xml
File docs/topics/impala_ssl.xml:
PS1, Line 39:
> Let's start the text on the line after the tag.
Done
PS1, Line 44: