Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2BA1C200C15 for ; Wed, 8 Feb 2017 07:42:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2A14D160B5A; Wed, 8 Feb 2017 06:42:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7266D160B4E for ; Wed, 8 Feb 2017 07:42:56 +0100 (CET) Received: (qmail 4854 invoked by uid 500); 8 Feb 2017 06:42:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 4843 invoked by uid 99); 8 Feb 2017 06:42:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Feb 2017 06:42:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E7634C05D7 for ; Wed, 8 Feb 2017 06:42:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id PLzgtBfDKyCB for ; Wed, 8 Feb 2017 06:42:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 821AF5F1E9 for ; Wed, 8 Feb 2017 06:42:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v186gphm024086; Wed, 8 Feb 2017 06:42:51 GMT Message-Id: <201702080642.v186gphm024086@ip-10-146-233-104.ec2.internal> Date: Wed, 8 Feb 2017 06:42:51 +0000 From: "Ishaan Joshi (Code Review)" To: David Knupp , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Mostafa Mokhtar , Matthew Jacobs , Michael Brown Reply-To: ishaan@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4839=3A_Remove_implicit_=27localhost=27_for_KUDU_MASTER_HOSTS=0A?= X-Gerrit-Change-Id: I9df71480a165f4ce21ae3edab6ce7227fbf76f77 X-Gerrit-ChangeURL: X-Gerrit-Commit: c3ff02e6c5053d4876495ed9c9849892f59c41a9 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 08 Feb 2017 06:42:57 -0000 Ishaan Joshi has posted comments on this change. Change subject: IMPALA-4839: Remove implicit 'localhost' for KUDU_MASTER_HOSTS ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5877/7/tests/conftest.py File tests/conftest.py: Line 317: try: With a yield fixture, py.test treats everything after the yield as teardown, so you probably don't need the finally. Additionally, if you're at 2.10 or above, you don't even need the yield fixture marker. Ref: http://doc.pytest.org/en/latest/fixture.html#fixture-finalization-executing-teardown-code -- To view, visit http://gerrit.cloudera.org:8080/5877 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9df71480a165f4ce21ae3edab6ce7227fbf76f77 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Ishaan Joshi Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Michael Brown Gerrit-Reviewer: Mostafa Mokhtar Gerrit-HasComments: Yes