Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id F1306200C14 for ; Tue, 7 Feb 2017 21:59:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id EFC96160B3E; Tue, 7 Feb 2017 20:59:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 45035160B32 for ; Tue, 7 Feb 2017 21:59:11 +0100 (CET) Received: (qmail 37434 invoked by uid 500); 7 Feb 2017 20:59:10 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 37417 invoked by uid 99); 7 Feb 2017 20:59:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Feb 2017 20:59:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D078218C401 for ; Tue, 7 Feb 2017 20:59:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aTfgcN9j47lM for ; Tue, 7 Feb 2017 20:59:08 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9F3695FB76 for ; Tue, 7 Feb 2017 20:59:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v17Kx7so006126; Tue, 7 Feb 2017 20:59:07 GMT Message-Id: <201702072059.v17Kx7so006126@ip-10-146-233-104.ec2.internal> Date: Tue, 7 Feb 2017 20:59:07 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3909_=28follow-up=29=3A_Properly_qualify_min=28=29_and_max=28=29_in_header=0A?= X-Gerrit-Change-Id: If8381d5b1fa072e89ac1f7f54959c02bf8e43b4b X-Gerrit-ChangeURL: X-Gerrit-Commit: 146e5b455740a71f704876d883edc0a8e94652cb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 07 Feb 2017 20:59:12 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-3909 (follow-up): Properly qualify min() and max() in header ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5916/2//COMMIT_MSG Commit Message: Line 14: I tried to make a static_assert method that complained if names.h was > clang-tidy can check this, IIRC: Can it check if a using statement is transitively included? It wasn't clear from those links. -- To view, visit http://gerrit.cloudera.org:8080/5916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8381d5b1fa072e89ac1f7f54959c02bf8e43b4b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes