Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7434C200C13 for ; Mon, 6 Feb 2017 23:04:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 72C15160B62; Mon, 6 Feb 2017 22:04:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BBEDE160B53 for ; Mon, 6 Feb 2017 23:04:15 +0100 (CET) Received: (qmail 48620 invoked by uid 500); 6 Feb 2017 22:04:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 48608 invoked by uid 99); 6 Feb 2017 22:04:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 22:04:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 550DD1A077E for ; Mon, 6 Feb 2017 22:04:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id iLJQDrvRLVzf for ; Mon, 6 Feb 2017 22:04:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 830CA5F1E9 for ; Mon, 6 Feb 2017 22:04:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v16M457V012842; Mon, 6 Feb 2017 22:04:05 GMT Message-Id: <201702062204.v16M457V012842@ip-10-146-233-104.ec2.internal> Date: Mon, 6 Feb 2017 22:04:05 +0000 From: "Zach Amsden (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Michael Ho , Alex Behm , Tim Armstrong Reply-To: zamsden@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4729=3A_Implement_REPLACE=28=29=0A?= X-Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 X-Gerrit-ChangeURL: X-Gerrit-Commit: 681accc6cedba55b433e3150081c6105c44dd42c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 06 Feb 2017 22:04:16 -0000 Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/11/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS11, Line 288: haystack.len - pattern.len + replace.len > Actually I can't. The subtraction has to happen first so the we don't over disregard - now that I have delta this doesn't actually matter. -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes