Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 141C5200C21 for ; Mon, 6 Feb 2017 05:59:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 12CB8160B65; Mon, 6 Feb 2017 04:59:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 595DE160B59 for ; Mon, 6 Feb 2017 05:59:08 +0100 (CET) Received: (qmail 67719 invoked by uid 500); 6 Feb 2017 04:59:07 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 67708 invoked by uid 99); 6 Feb 2017 04:59:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2017 04:59:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BFBF7C0027 for ; Mon, 6 Feb 2017 04:59:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id AKaXBNr0Ful7 for ; Mon, 6 Feb 2017 04:59:06 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id DBB615FB5B for ; Mon, 6 Feb 2017 04:59:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v164x0rJ028510; Mon, 6 Feb 2017 04:59:00 GMT Message-Id: <201702060459.v164x0rJ028510@ip-10-146-233-104.ec2.internal> Date: Mon, 6 Feb 2017 04:59:00 +0000 From: "Bharath Vissapragada (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Alex Behm Reply-To: bharathv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-1427=3A_Improvements_to_=22Unknown_disk-ID=22_warning=0A?= X-Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 01abb7a99167402aab2bca9cfc27ffd2b9225562 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Mon, 06 Feb 2017 04:59:09 -0000 Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5828/5//COMMIT_MSG Commit Message: Line 9: This commit, > remove Done http://gerrit.cloudera.org:8080/#/c/5828/5/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: Line 610: output.append(String.format("%smissing disk ids: " + > let's not output this when there are no missing disk ids Done -- To view, visit http://gerrit.cloudera.org:8080/5828 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bharath Vissapragada Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: Yes