impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add a build flag for the undefined behavior sanitizer, aka "ubsan".
Date Tue, 28 Feb 2017 22:53:51 GMT
Jim Apple has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6186

Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan".
......................................................................

Add a build flag for the undefined behavior sanitizer, aka "ubsan".

Ubsan checks for undefined behavior according to the C++
standard. Some of this behavior has been known to be exploited by
optimizing compilers to produce bizarre results, like taking both
branches of a conditional.

This patch only adds build options; fixing the errors ubsan finds, as
well as adding any tests that a build is free from ubsan errors, are
not covered in this patch.

Change-Id: I03044c657ac171daa0648f833bbbeed7bdde49cb
---
M CMakeLists.txt
M be/CMakeLists.txt
M bin/make_impala.sh
M bin/run-backend-tests.sh
M bin/start-impalad.sh
M buildall.sh
6 files changed, 36 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/86/6186/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6186
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I03044c657ac171daa0648f833bbbeed7bdde49cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>

Mime
View raw message