impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
Date Sat, 18 Feb 2017 04:37:22 GMT
Zach Amsden has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6068

Change subject: IMPALA-4936 and IMPALA-4915: Fix decimal overflow test
......................................................................

IMPALA-4936 and IMPALA-4915: Fix decimal overflow test

The root cause of both behaviors turned out to be the same - a
missing std:: caused the wrong abs() function to be used.  Due
to details of IEEE floating point representation, this actually
masked another bug, as NaN is often represented as all 1-bits,
which fails the overflow test.  Since the implicit conversion to
int lost precision, we ended up storing large numbers that don't
actually represent valid decimal numbers in the range when the
value happened to be +/- Infinity.  This caused the rendering
back to ASCII characters to go awry, but is otherwise harmless.

Testing: updated expr test with correctly fixed test cases.
For some reason, it seemed the test passed before that, so it
is possible that it isn't correctly validating some of the non
decimal V2 clauses.  Will investigate further.

Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63
---
M be/src/exprs/expr-test.cc
M be/src/runtime/decimal-value.inline.h
2 files changed, 7 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/6068/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6068
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8de7440a585c1d3d937fcbb435b9ead77e7b5a63
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message