impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4643: [DOCS] Genericize HBase topic, esp links
Date Wed, 01 Feb 2017 23:39:35 GMT
John Russell has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/5858

Change subject: IMPALA-4643: [DOCS] Genericize HBase topic, esp links
......................................................................

IMPALA-4643: [DOCS] Genericize HBase topic, esp links

The Impala + HBase page included a little Cloudera-specific wording,
i.e. "Cloudera recommends...".

The main Cloudera-specific details were links to HBase documentation
hosted on cloudera.com. I made those links use the keydef/keyref
indirection mechanism and edited the URLs to point to the upstream
Apache HBase docs.

Centralizing these links also makes the Impala + HBase source cleaner,
because the link text doesn't need to be inside an <xref>...</xref>
pair on the page itself. The link ends up being just
"See <xref keyref="whatever"/>".

After this change, there's no more 'Cloudera' visible in the text of
the relevant HTML page, including the 'view source' view. (Previously,
the cloudera.com links would have shown up but only findable via
'view source'.

Change-Id: Ic36ad02766a0f8945759c698fa1c5760dc12d0cb
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_hbase.xml
2 files changed, 15 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/5858/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5858
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic36ad02766a0f8945759c698fa1c5760dc12d0cb
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>

Mime
View raw message