impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Fix parquet table writer dictionary leak
Date Tue, 28 Feb 2017 22:21:45 GMT
Tim Armstrong has posted comments on this change.

Change subject: Fix parquet table writer dictionary leak
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/6181/1/be/src/exec/hdfs-table-sink.cc
File be/src/exec/hdfs-table-sink.cc:

Line 334:       OutputPartition* deletable_partition = current_clustered_partition_->first;
Why not just delete it here and save the temp variable?


Line 336:       delete(deletable_partition);
delete deletable_partition; - delete is a keyword instead of a function


Line 579:     OutputPartition* partition = new OutputPartition();
Could we use a unique_ptr here and in PartitionPair to make the ownership explicit and cleanup
automatic? I think this would be a unique_ptr, and it would be move()d into the map .


Line 587:       delete(partition);
delete partition;


-- 
To view, visit http://gerrit.cloudera.org:8080/6181
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e354086ad24071d4fbf823f25f5df23933688f
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message