impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: add DECIMAL test case to strict mode tests
Date Tue, 28 Feb 2017 20:27:54 GMT
Hello Zach Amsden,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6150

to look at the new patch set (#2).

Change subject: IMPALA-4810: add DECIMAL test case to strict_mode tests
......................................................................

IMPALA-4810: add DECIMAL test case to strict_mode tests

The string parsing code already errors if the decimal column either
overflows or underflows (i.e. loses scale). Let's just add a test
case.

Change-Id: Idd66c0fb5a4d201919d39f73dea08b87339d6469
---
M testdata/data/overflow.txt
M testdata/datasets/functional/functional_schema_template.sql
M testdata/workloads/functional-query/queries/QueryTest/strict-mode-abort.test
M testdata/workloads/functional-query/queries/QueryTest/strict-mode.test
4 files changed, 31 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/50/6150/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idd66c0fb5a4d201919d39f73dea08b87339d6469
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>

Mime
View raw message