impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4997: Fix overflows in Sorter::TupleIterator
Date Tue, 28 Feb 2017 19:31:27 GMT
Hello Marcel Kornacker, Jim Apple,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6169

to look at the new patch set (#7).

Change subject: IMPALA-4997: Fix overflows in Sorter::TupleIterator
......................................................................

IMPALA-4997: Fix overflows in Sorter::TupleIterator

Various places in Sorter::TupleIterator multiply two int values
(Sorter::Run::block_capacity_ and Sorter::TupleIterator::block_index_)
and assigned the result to an int64_t value
(Sorter::TupleIterator::buffer_start_index_). One such occurrence is in
be/src/runtime/sorter.cc#L1080. This multiplication could overflow for
runs with a large number of rows. Changing one of the operands to
int64_t fixes this.

To test this Matt Mulder ran the failing query from IMPALA-4997 on a
private cluster and it succeeded.

Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8
---
M be/src/runtime/sorter.cc
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/6169/7
-- 
To view, visit http://gerrit.cloudera.org:8080/6169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iea22aa96e0cc86102b60c6e551e9e607cef485c8
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message