impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
Date Tue, 28 Feb 2017 15:44:07 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-4995: Fix integer overflow in TopNNode::PrepareForOutput
......................................................................


Patch Set 1: Code-Review+2

This fix looks good but see my comment on the JIRA - it may make sense to switch to the sort
operator when limit + offset is large since there are other potential problems with the TopN
node in those cases

-- 
To view, visit http://gerrit.cloudera.org:8080/6171
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5048ec67d8f086346220d56e027e6583fbb5ddad
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message