impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove deadcode from frontend - Part 1
Date Tue, 28 Feb 2017 06:06:24 GMT
Alex Behm has posted comments on this change.

Change subject: Remove deadcode from frontend - Part 1
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6172/1/fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java
File fe/src/main/java/org/apache/impala/analysis/AnalyticInfo.java:

Line 162
Yikes! We don't call this anywhere? Seems like we should.


http://gerrit.cloudera.org:8080/#/c/6172/1/fe/src/main/java/org/apache/impala/analysis/PartitionListItem.java
File fe/src/main/java/org/apache/impala/analysis/PartitionListItem.java:

Line 23
Nice


-- 
To view, visit http://gerrit.cloudera.org:8080/6172
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3fa810cf4eaf9f9ff545fe80a11bc62619039224
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message