impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014
Date Tue, 28 Feb 2017 00:28:44 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014

Patch Set 6: Code-Review+2

(1 comment)

This is okay with me, though I still think it would be nice to group the code that does ambiguity
checking close together (or even factor into a separate subroutine). If you do that, I can
take another look. Otherwise, okay to go with this change, but please fix the nit with DCHECK_LT.
File be/src/exprs/

Line 133:     // NULL".
> For some context, you can take a look at this discussion:
Sure, returning null seems reasonable in these cases. It would just be nice to factor the
code in a way such that all the code that determines these ambiguous cases is factored into
a single location. Is it the local_date_time constructor that does the validation in other

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Jim Apple <>
Gerrit-Reviewer: Matthew Jacobs <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message