impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-5001: Redownload dependencies if toolchain ID changes
Date Tue, 28 Feb 2017 00:12:15 GMT
Hello Matthew Jacobs,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6166

to look at the new patch set (#2).

Change subject: IMPALA-5001: Redownload dependencies if toolchain ID changes
......................................................................

IMPALA-5001: Redownload dependencies if toolchain ID changes

To allow for the situation where a dependency's compile flags
change (but otherwise nothing else does, including the version), this
patch adds the toolchain build ID to the version information checked by
bootstrap_toolchain.py when it decides whether to download a new
dependency version.

Also add a small amount of logging to make it clearer what the script is
doing.

Change-Id: I77fcfbeb4594b14da2048a9c31458f634600c1e6
---
M bin/bootstrap_toolchain.py
1 file changed, 25 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/6166/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I77fcfbeb4594b14da2048a9c31458f634600c1e6
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>

Mime
View raw message