impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2328: Address additional comments
Date Mon, 27 Feb 2017 23:07:34 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2328: Address additional comments

Patch Set 2:


Thanks for the review. Please see PS3.
File be/src/exec/

Line 487:   DCHECK_EQ(min_max_tuple_desc->slots().size(), min_max_conjuncts_ctxs_.size());

Line 494:     SchemaNode* node = nullptr;
> nullptr

Line 501:       // We are selecting a column that is not in the file. We would set its slot
> Remove "In this case", that's clear.

Line 502:       // during the scan, so any predicate would evaluate to false. Return early.
> Suggest minor rewording for clarity:

Line 507:     if (pos_field) {
> Does the FE guarantee that such predicates are not sent to the BE for min/m
I changed the code in to handle this correctly. I also added a test with
that query.
File fe/src/main/java/org/apache/impala/planner/

Line 342:       if (slot == null) continue;
> You can check slot.getDesc().getColumn() to see if the slot corresponds to 
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 234: create table name_resolve stored as parquet as select * from functional_parquet.alltypessmall;
> no need for this if we are using unique_database

Line 256: # Predicates with explicit casts are not supported when evaluating parquet::Statistics.
> The above test seems sufficient.

Line 264: ---- QUERY
> Might be good to have an example here that demonstrates why it's not easy t
File tests/query_test/

Line 24:   This suite tests runtime optimizations based on Parquet statistics.
> Tests runtime optimizations based on Parquet statistics?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Lars Volker <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message