impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler
Date Mon, 27 Feb 2017 21:20:08 GMT
Hello Marcel Kornacker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6149

to look at the new patch set (#3).

Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler
......................................................................

Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler

For the last five years we've had the Scheduler superclass with exactly
one implementation, SimpleScheduler. This patch collapses that hierarchy
into just one concrete implementation called Scheduler.

Also fixed up some includes in (the new) scheduler.h based on the
include-what-you-use tool.

Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e
---
M be/src/runtime/exec-env.cc
M be/src/scheduling/CMakeLists.txt
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/query-schedule.h
R be/src/scheduling/scheduler-test-util.cc
R be/src/scheduling/scheduler-test-util.h
R be/src/scheduling/scheduler-test.cc
R be/src/scheduling/scheduler.cc
M be/src/scheduling/scheduler.h
D be/src/scheduling/simple-scheduler.h
M be/src/service/impala-server.cc
M fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
M fe/src/main/java/org/apache/impala/util/MembershipSnapshot.java
13 files changed, 633 insertions(+), 695 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/6149/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>

Mime
View raw message