impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler
Date Mon, 27 Feb 2017 20:43:12 GMT
Marcel Kornacker has posted comments on this change.

Change subject: Remove Scheduler abstract interface, rename SimpleScheduler -> Scheduler
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6149/2/be/src/scheduling/simple-scheduler.cc
File be/src/scheduling/simple-scheduler.cc:

Line 315:           NULL;
could you please restore the old formatting here? I find the autoformatting of ternary expressions
messed up.


Line 391:     TUniqueId instance_id = fragment_params->is_coord_fragment ?
same here


-- 
To view, visit http://gerrit.cloudera.org:8080/6149
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70e0b002fa56d3ba1c3b34f03ae05f4042ac309e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message