impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4546: Fix Moscow timezone conversion after 2014
Date Mon, 27 Feb 2017 20:25:58 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4546: Fix Moscow timezone conversion after 2014
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5969/6/be/src/exprs/timestamp-functions.cc
File be/src/exprs/timestamp-functions.cc:

Line 133:     // NULL".
> Okay, I guess what you're saying is that for the ts_val's in this range, th
For some context, you can take a look at this discussion: https://gerrit.cloudera.org/#/c/5969/2/be/src/exprs/expr-test.cc@3720

Since in other ambiguous cases (during DST changes), Impala returns null, (this is what boost
does), we decided to do the same thing here.

This case is different than 2011 because in 2011 the timezone rule change happened at the
same time as DST transition.


PS6, Line 205: March 27, 2011
> this doesn't seem to match the code for March 28-30th... what's the story w
The March 28th transition happened at the same time as a DST change.


PS6, Line 205: NOTE: We currently
             :       // do not handle Moscow time conversions for dates before January 19,
1992
             :       // correctly (Impala incorrectly thinks the Moscow timezone is UTC+3
with DST
             :       // instead of UTC+2 with DST for those dates).
> is this a pre-existing bug? is there a jira?
The preexisting bug is that we do not support timezone rule changes in general. This is a
known issue. For example, Moscow time rules changed 8 times in the last 100 years (So there
can be several JIRAS, one of which addresses the 1992 rule change).


-- 
To view, visit http://gerrit.cloudera.org:8080/5969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6e3f2c9f6ba29749a26bc1087e664637bc02528
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message