impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3079: Fix sequence file writer
Date Mon, 27 Feb 2017 19:51:34 GMT
Michael Ho has posted comments on this change.

Change subject: IMPALA-3079: Fix sequence file writer
......................................................................


Patch Set 1:

(4 comments)

Some initial comments...

http://gerrit.cloudera.org:8080/#/c/6107/1/be/src/exec/read-write-util-test.cc
File be/src/exec/read-write-util-test.cc:

PS1, Line 88:  
nit: blank space.


http://gerrit.cloudera.org:8080/#/c/6107/1/be/src/util/compress.cc
File be/src/util/compress.cc:

PS1, Line 209: each preceded with an integer size
, each preceded with an integer for its size.


PS1, Line 210: // For testing purposes we are going to generate two blocks if input_length
>= 2.
That seems a bit inefficient to split into two blocks for input_length == 2. Should we move
this threshold higher and improve the test cases instead ?


PS1, Line 235: uint8_t* sizep;
The declaration can be moved into the loop body.


-- 
To view, visit http://gerrit.cloudera.org:8080/6107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0db642ad35132a9a5a6611810a6cafbbe26e7487
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Attila Jeges <attilaj@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message