impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-2328: Address additional comments
Date Sat, 25 Feb 2017 01:08:02 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-2328: Address additional comments

Patch Set 1:

File be/src/exec/

Line 494:     SchemaNode* node = NULL;

Line 501:       // In this case, we are selecting a column that is not in the file. We would
Remove "In this case", that's clear.

Line 502:       // this column with NULL during the scan, so any predicate would fail. Return
Suggest minor rewording for clarity:

We would set its slot to NULL during the scan, ... so any predicate would evaluate to false.

Line 507:     if (pos_field) {
Does the FE guarantee that such predicates are not sent to the BE for min/max filtering? 

You can try something like:

select pos from functional_parquet.complextypestbl.int_array where pos < 5;

I believe it will hit the DCHECK here.
File fe/src/main/java/org/apache/impala/planner/

Line 342:       if (slot == null) continue;
You can check slot.getDesc().getColumn() to see if the slot corresponds to a real column.
If getColumn() returns null, then you can have a 'pos' slot.
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 234: drop table if exists name_resolve;
no need for this if we are using unique_database

Line 256: ---- QUERY
The above test seems sufficient.

Line 264: select count(*) from functional_parquet.alltypessmall where '0' > cast(tinyint_col
as string)
Might be good to have an example here that demonstrates why it's not easy to support explicit
casts. Maybe cast(bigint_col as tinyint) < 10
File tests/query_test/

Line 24:   This suite tests support for Parquet statistics using SQL queries.
Tests runtime optimizations based on Parquet statistics?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I54c205fad7afc4a0b0a7d0f654859de76db29a02
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-HasComments: Yes

View raw message