impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
Date Sat, 25 Feb 2017 00:07:34 GMT
John Russell has posted comments on this change.

Change subject: IMPALA-3402: [DOCS] Remove/reword all CDH 4 references
......................................................................


Patch Set 2:

(1 comment)

Since I was help up in finalizing this review, I repurposed it to be more substantial and
will ask Ambreen to doublecheck again. (Original patchset was intended to be a minor change
for gerrit demo purposes.)

http://gerrit.cloudera.org:8080/#/c/6146/2/docs/topics/impala_decimal.xml
File docs/topics/impala_decimal.xml:

PS2, Line 721: 
> Is there an equivalent Impala version number you could reference?
No, this was back in the days before there was any close correspondences between the Impala
and CDH numbers. It is purely a case of "use really old CDH, watch out". Now that CDH 4 is
end-of-maintenance, even in CDH docs it's fair game to remove such references.


-- 
To view, visit http://gerrit.cloudera.org:8080/6146
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ffb400a244930134705b0f0039087506f5e70d3
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message