impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4982: Add parquet stats test
Date Fri, 24 Feb 2017 01:35:55 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4982: Add parquet stats test
......................................................................


Patch Set 5:

(4 comments)

Thank you for the review. Please see PS5.

http://gerrit.cloudera.org:8080/#/c/6130/4/testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-stats.test
File testdata/workloads/functional-query/queries/QueryTest/nested-types-scanner-stats.test:

Line 3
> call the file nested-types-parquet-stats.test to be consistent with your ot
Done


http://gerrit.cloudera.org:8080/#/c/6130/4/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 233
> remove tests from here
:( Sorry for missing this.


http://gerrit.cloudera.org:8080/#/c/6130/4/tests/query_test/test_nested_types.py
File tests/query_test/test_nested_types.py:

Line 78:   def test_parquet_stats(self, vector):
> test_parquet_stats:
Done


Line 79:     """Queries that test evaluation of Parquet row group statistics."""
> Parquet row group statistics
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If81c8a1ecea937794885d4e5e7bf765bd238f5fb
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message