impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4982: Add parquet stats test
Date Fri, 24 Feb 2017 01:19:55 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-4982: Add parquet stats test
......................................................................


Patch Set 3:

(2 comments)

Thank you for the review! Please see my comments and PS4.

http://gerrit.cloudera.org:8080/#/c/6130/3/testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test
File testdata/workloads/functional-query/queries/QueryTest/parquet_stats.test:

Line 232: ---- QUERY
> Move these into a separate .test file or find another suitable test/file (e
Thank you for catching this. I moved the tests into a new file, anticipating we will add more
tests there as we add support for filtering nested data.


Line 252: # Nested columns do not support stats based filtering.
> Do we have a JIRA for this yet? We can definitely fix this.
I opened IMPALA-4985 to track this.


-- 
To view, visit http://gerrit.cloudera.org:8080/6130
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If81c8a1ecea937794885d4e5e7bf765bd238f5fb
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message