impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Three misc webpage changes
Date Thu, 23 Feb 2017 17:32:40 GMT
Matthew Jacobs has posted comments on this change.

Change subject: Three misc webpage changes
......................................................................


Patch Set 1: Code-Review+2

> Thanks for the reviews!
 > 
 > > seems fine but I don't really know jquery
 > 
 > If it makes it easier, this is basically C&P code - see e.g.
 > https://github.com/apache/incubator-impala/blob/master/www/sessions.tmpl
 > for another example of a sortable table already in master.
 > 

It does - thanks

 > > Is there a plan to migrate other HTML tables to DataTables?
 > (E.g., Queries, Query Locations, ...)
 > 
 > No particular plans - it's so easy to do I think anyone can do it
 > when they see a need.

-- 
To view, visit http://gerrit.cloudera.org:8080/6045
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica0578dabb7e27e6fd45ee4f31a1418ac3adc891
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message